WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.52k stars 998 forks source link

fix(glossary): skip variants inclusion for machinery and checks #11884

Closed nijel closed 3 months ago

nijel commented 3 months ago

Proposed changes

Only matching source strings should be included, the variants are useful for display only.

Fixes #11883

Checklist

Other information

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (6aee586) to head (875580f). Report is 3978 commits behind head on main.

Files with missing lines Patch % Lines
weblate/glossary/models.py 57.14% 5 Missing and 1 partial :warning:
weblate/machinery/microsoft.py 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884/graphs/tree.svg?width=650&height=150&src=pr&token=9rzx9QBq35&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) ```diff @@ Coverage Diff @@ ## main #11884 +/- ## ========================================== - Coverage 90.82% 90.60% -0.22% ========================================== Files 554 576 +22 Lines 57306 58777 +1471 Branches 9122 9384 +262 ========================================== + Hits 52046 53254 +1208 - Misses 3640 3829 +189 - Partials 1620 1694 +74 ``` | [Files with missing lines](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) | Coverage Δ | | |---|---|---| | [weblate/checks/glossary.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&filepath=weblate%2Fchecks%2Fglossary.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9jaGVja3MvZ2xvc3NhcnkucHk=) | `78.72% <100.00%> (+0.46%)` | :arrow_up: | | [weblate/checks/same.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&filepath=weblate%2Fchecks%2Fsame.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9jaGVja3Mvc2FtZS5weQ==) | `97.77% <ø> (-0.05%)` | :arrow_down: | | [weblate/machinery/openai.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&filepath=weblate%2Fmachinery%2Fopenai.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9tYWNoaW5lcnkvb3BlbmFpLnB5) | `72.28% <ø> (-3.39%)` | :arrow_down: | | [weblate/machinery/microsoft.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&filepath=weblate%2Fmachinery%2Fmicrosoft.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9tYWNoaW5lcnkvbWljcm9zb2Z0LnB5) | `69.51% <0.00%> (+0.17%)` | :arrow_up: | | [weblate/glossary/models.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884?src=pr&el=tree&filepath=weblate%2Fglossary%2Fmodels.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9nbG9zc2FyeS9tb2RlbHMucHk=) | `86.44% <57.14%> (-1.30%)` | :arrow_down: | ... and [323 files with indirect coverage changes](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11884/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)