WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.52k stars 998 forks source link

fix(formats): avoid CSV autodetection for generated CSV files from Excel #11885

Closed nijel closed 3 months ago

nijel commented 3 months ago

Proposed changes

Depends on https://github.com/translate/translate/pull/5267

Fixes #11872

Checklist

Other information

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.60%. Comparing base (6aee586) to head (a51ff42). Report is 3978 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885/graphs/tree.svg?width=650&height=150&src=pr&token=9rzx9QBq35&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) ```diff @@ Coverage Diff @@ ## main #11885 +/- ## ========================================== - Coverage 90.82% 90.60% -0.22% ========================================== Files 554 576 +22 Lines 57306 58777 +1471 Branches 9122 9383 +261 ========================================== + Hits 52046 53254 +1208 - Misses 3640 3829 +189 - Partials 1620 1694 +74 ``` | [Files with missing lines](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) | Coverage Δ | | |---|---|---| | [weblate/formats/external.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885?src=pr&el=tree&filepath=weblate%2Fformats%2Fexternal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9mb3JtYXRzL2V4dGVybmFsLnB5) | `88.37% <100.00%> (-2.81%)` | :arrow_down: | | [weblate/formats/ttkit.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885?src=pr&el=tree&filepath=weblate%2Fformats%2Fttkit.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9mb3JtYXRzL3R0a2l0LnB5) | `90.84% <100.00%> (-0.57%)` | :arrow_down: | ... and [326 files with indirect coverage changes](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11885/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)