WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.33k stars 970 forks source link

Replace misaka with mistletoe #11905

Closed gersona closed 4 days ago

gersona commented 1 week ago

fixes #9786

Proposed changes

Re-implement the markdown rendering module with the mistletoe library since mikasa is no longer maintained

Checklist

Other information

I need help figuring out how to properly remove the dependency references to mikasa in the pyproject.toml and requirements.py files

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (6aee586) to head (765afda). Report is 2307 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905/graphs/tree.svg?width=650&height=150&src=pr&token=9rzx9QBq35&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) ```diff @@ Coverage Diff @@ ## main #11905 +/- ## ========================================== - Coverage 90.82% 90.61% -0.21% ========================================== Files 554 581 +27 Lines 57306 58966 +1660 Branches 9122 9408 +286 ========================================== + Hits 52046 53434 +1388 - Misses 3640 3836 +196 - Partials 1620 1696 +76 ``` | [Files](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) | Coverage Δ | | |---|---|---| | [weblate/utils/tests/test\_markdown.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905?src=pr&el=tree&filepath=weblate%2Futils%2Ftests%2Ftest_markdown.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS91dGlscy90ZXN0cy90ZXN0X21hcmtkb3duLnB5) | `100.00% <100.00%> (ø)` | | | [weblate/utils/markdown.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905?src=pr&el=tree&filepath=weblate%2Futils%2Fmarkdown.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS91dGlscy9tYXJrZG93bi5weQ==) | `96.49% <94.44%> (-3.51%)` | :arrow_down: | ... and [340 files with indirect coverage changes](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11905/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)
nijel commented 5 days ago

Scheduled for merge, thanks for your contribution!