Open gzm0 opened 3 days ago
Still WIP, because I have not figured out how to:
Any help greatly appreciated.
Question regarding review / commits: Do you prefer if I keep a commit history for evolution and squash at the end or if I prepare the branch as I would propose to merge it on every review round?
Also: I'm still trying to figure out how to actually run my unit tests and how to log into the local dev weblate (as admin that its). If you have pointers, highly appreciated.
I usually squash commits when merging, so I'm not really concerned about evolution of the commits.
Ah, I didn't notice this:
* run unit tests
This should be documented at https://docs.weblate.org/en/latest/contributing/tests.html
* log into the development weblate (I managed to start it).
If you're using rundev.sh
, the admin password was printed on the first start. You can create new admin or update the password using https://docs.weblate.org/en/latest/admin/management.html#createadmin
Proposed changes
Do not copy the notes (comments) from the template/source when adding a translation for a key (in monolingual formats).
This fixes #11133. Copying the notes is problematic because the are not synced when they are updated. As a result, they can get out of date.
The implicit assumption behind this change is that most users only care about comments in source files (but not in target files).
Checklist
Other information