WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.56k stars 1.01k forks source link

Download translation & Weblate-specific data #1194

Closed marcperrin closed 5 years ago

marcperrin commented 8 years ago

Hello, When downloading for offline translation, you get the store data but you never get Weblate-specific data such as Suggestions, Weblate Comments, or Weblate source string tags like check-length etc. Do you think it would be appropriate to get this data at download* so that offline translator has a level of information closer to online translation? Thanks!

*) I guess all formats have a comment zone where all of this could be fed. For .po, we could be a bit more specific, as Weblate comments and suggestions could qualify as translator comments (#) (rather than extracted comments #.), and for Weblate flags, maybe flags? (#,) (Or maybe you'd envision that as a separate downloaded file??)

nijel commented 8 years ago

Something like this is definitely possible, though it really needs good specification to make it usable.

For example using flags for anything non standard in Gettext is quite tricky, many of the tools do silently strip non standard flags...

marcperrin commented 8 years ago

OK then, the less risky approach would be to keep everything as comments (e.g. # [Weblate data] { json data... }) You might also get problems with the "Merge translation comments" option at upload, but then again, I think there is already a problem with that option, as I tend to get duplicated comments if I keep this box checked.

nijel commented 5 years ago

Flags could be indeed exported to Xliff and gettext PO files (the latter is blocked by https://github.com/translate/translate/pull/3913 as they will otherwise be completely messed up). That's something I will definitely do for 3.9 release.

Comments could be turned into xliff notes and gettext translator comments.

I'm not really sure about suggestions as those really do not translate well into anything existing.

nijel commented 5 years ago

Implementation for above outlined case is in https://github.com/WeblateOrg/weblate/pull/2962

nijel commented 5 years ago

Thank you for your report, the issue you have reported has just been fixed.