WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.33k stars 970 forks source link

fix(add-ons): disable discovery add-on on site and project wide #11943

Closed nijel closed 3 days ago

nijel commented 3 days ago

Proposed changes

It currently shows preview based on the component, so it crashes without it.

While technically there is no reason not to allow it, it is unlikely that a single discovery add-on configuration would work on different repositories.

Fixes #11939 Fixes WEBLATE-QC

Checklist

Other information

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (6aee586) to head (14fa77d). Report is 2318 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943/graphs/tree.svg?width=650&height=150&src=pr&token=9rzx9QBq35&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) ```diff @@ Coverage Diff @@ ## main #11943 +/- ## ========================================== - Coverage 90.82% 90.62% -0.21% ========================================== Files 554 581 +27 Lines 57306 58994 +1688 Branches 9122 9413 +291 ========================================== + Hits 52046 53461 +1415 - Misses 3640 3836 +196 - Partials 1620 1697 +77 ``` | [Files](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg) | Coverage Δ | | |---|---|---| | [weblate/addons/base.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943?src=pr&el=tree&filepath=weblate%2Faddons%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9hZGRvbnMvYmFzZS5weQ==) | `87.39% <100.00%> (-1.21%)` | :arrow_down: | | [weblate/addons/discovery.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943?src=pr&el=tree&filepath=weblate%2Faddons%2Fdiscovery.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9hZGRvbnMvZGlzY292ZXJ5LnB5) | `90.62% <100.00%> (ø)` | | | [weblate/api/serializers.py](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943?src=pr&el=tree&filepath=weblate%2Fapi%2Fserializers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg#diff-d2VibGF0ZS9hcGkvc2VyaWFsaXplcnMucHk=) | `92.26% <0.00%> (-0.20%)` | :arrow_down: | ... and [339 files with indirect coverage changes](https://app.codecov.io/gh/WeblateOrg/weblate/pull/11943/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WeblateOrg)