(weblate.C040) Include hostname only in the AZURE_DEVOPS_CREDENTIALS keys: https://dev.azure.com

Aspyryan commented 2 days ago

Describe the issue

I cannot get azure pull requests to work since the documentation does not provide full insight. I have put the following in my docker-compose.override.yml:

version: "3"
services:
  weblate:
    ports:
      - 80:8080
    environment:
      WEBLATE_EMAIL_HOST: smtp.example.com
      WEBLATE_EMAIL_HOST_USER: user
      WEBLATE_EMAIL_HOST_PASSWORD: pass
      WEBLATE_SERVER_EMAIL: weblate@example.com
      WEBLATE_DEFAULT_FROM_EMAIL: weblate@example.com
      WEBLATE_SITE_DOMAIN: weblate.example.com
      WEBLATE_ADMIN_PASSWORD: <REDACTED>
      WEBLATE_ADMIN_EMAIL: weblate.admin@example.com
      WEBLATE_AZURE_DEVOPS_USERNAME: proof of concepts # <-- this does have spaces
      WEBLATE_AZURE_DEVOPS_ORGANIZATION: org
      WEBLATE_AZURE_DEVOPS_TOKEN: <REDACTED>
      WEBLATE_AZURE_DEVOPS_HOST: https://dev.azure.com

I tried several different combinations but none seem to work. When leaving host I get ValueError: Incomplete AZURE_DEVOPS_CREDENTIALS configuration: missing WEBLATE_AZURE_DEVOPS_HOST but when leaving it in I get error above.

I already tried

[X] I've read and searched the documentation.
[X] I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

Follow installation manual at: https://docs.weblate.org/en/weblate-5.7.2/admin/install/docker.html#installation
Add the override settings as above

Expected behavior

Project to start or good documentation available

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

nijel commented 1 day ago

It should only include hostname, not a protocol, so it should be:

      WEBLATE_AZURE_DEVOPS_HOST: dev.azure.com

nijel commented 1 day ago

I've tried to clarify the error message in e78dde95d289c0c02ee0ad0dd30d1ea2cfff4714.

Aspyryan commented 1 day ago

Awesome thank you! should the TOKEN be a PAT or something else?

nijel commented 1 day ago

It can be any authentication token Azure DevOps supports, PAT will work as well.

github-actions[bot] commented 1 day ago

This issue has been marked as a question by a Weblate team member. Why? Because it belongs more to the professional Weblate Care or community Discussions than here. We strive to answer these reasonably fast here, too, but purchasing the support subscription is more responsible and faster for your business. And it makes Weblate stronger as well. Thanks!

In case your question is already answered, making a donation is the right way to say thank you!

WeblateOrg / weblate