WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.57k stars 1.01k forks source link

Include usernames in translator credits #12800

Open dumbmoron opened 5 days ago

dumbmoron commented 5 days ago

Describe the problem

Currently, the output for translator credits includes the translator's email, name, and change count.

Describe the solution you would like

It would be useful for me for automatic translation attribution if the output also included the account username of the translator.

Describe alternatives you have considered

It would probably be possible to pull out the username through some incantation of API calls, but it's not ideal considering this endpoint already has access to this information, and simply omits it.

github-actions[bot] commented 4 days ago

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

YukeHuang123 commented 4 days ago

Hi @nijel ,Can I take up this issue ?

notanshb commented 4 days ago

Hi @nijel would be glad to take this up

Humayun-23 commented 4 days ago

Hello, I would like to work on this issue.

nijel commented 3 days ago

Anybody is welcome to submit a pull request. The credits generating code is here:

https://github.com/WeblateOrg/weblate/blob/c8ecca099f75a110d8b8953356fc1be66c1a315a/weblate/trans/views/reports.py#L52-L92

YukeHuang123 commented 2 days ago

account username of the translator.

Hi @nijel, I’m encountering difficulties with the tests related to author usernames in the generate_credits function. The ReportsTest are failing, and I’m unsure why. Specifically, is the author_username field being used correctly to retrieve the username? Here is my implement on this issue: image

Thank you for your help!

harriebird commented 1 day ago

Hi guys, check my PR #12821 for this issue.