WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.49k stars 993 forks source link

Source links within submodules: It would be nice if they worked #4139

Open jepler opened 4 years ago

jepler commented 4 years ago

Is your feature request related to a problem? Please describe. In CircuitPython, we import additional source through git submodules. When a translator using weblate follows a link to a source file that is in a submodule, they are taken to a github 404 page instead of the correct page. Example: the 'source string location' in https://hosted.weblate.org/translate/circuitpython/main/fr/?offset=1&q=+location%3Aulab+&sort_by=-priority%2Cposition&checksum= is https://github.com/adafruit/circuitpython/blob/main/extmod/ulab/code/fft.c#L0 but because extmod/ulab is a submodule, it would actually need to be https://github.com/v923z/micropython-ulab/blob/master/code/filter.c#L0

Describe the solution you'd like If weblate understood the .gitmodules file, it could determine the correct URL. We could also generate some additional file within our git repo if weblate could support it. We probably can accept going to the main development branch of the submodule, not the specific ref that is committed---that would certainly be an improvement on the status quo.

Describe alternatives you've considered We can educate our translators on what to do when this situation arises, but no automatic way to resolve the problem has occurred to us. At this time, it's not feasible for us to remove the use of submodules or to perform the translation task in the submodule instead of the top level module.

Additional context This search should bring up a string that resides in a submodule: https://hosted.weblate.org/translate/circuitpython/main/fr/?offset=1&q=+location%3Aulab+&sort_by=-priority%2Cposition&checksum=

Thank you! We love weblate!

github-actions[bot] commented 4 years ago

This issue has been put aside. Currently, it is unclear whether it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users.