WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.63k stars 1.02k forks source link

Hide everything to guests #4617

Closed afeurra closed 4 years ago

afeurra commented 4 years ago

Describe the issue

I wish I could prevent guests to see any part of my installation. I have removed all roles from Guest group in Django but they can still see the language list (including percentages of completion) and users list. A clear and concise description of problem you are facing.

To Reproduce

Steps to reproduce the behavior:

(using hosted.weblate.org as example)

  1. Go to https://hosted.weblate.org/languages/ or https://hosted.weblate.org/user/
  2. See the lists of languages and users.
  3. Go to https://hosted.weblate.org/admin/
  4. Login as Admin
  5. Disable all permissions to Guests group
  6. Logout
  7. Repeat step 1
  8. See you can still see lists as at step 2

Expected behavior

Admin should be able to hide everything (include users list) to unathorized guests.

Server configuration and status

github-actions[bot] commented 4 years ago

This issue looks like a support question. We try to answer these reasonably fast, but in case you are looking for faster resolution, please consider purchasing support subscription and make Weblate stronger.

comradekingu commented 4 years ago

When is that not a good thing? Suggestions and available translations by default really helps quality and participation. Makes it easy to understand how to get into the process, and where.

If you are committing to a public Git repo or similar, everyone sees all the user accounts/e-mails anyhow.

nijel commented 4 years ago

Yes, the lists are still available, see https://docs.weblate.org/en/latest/admin/access.html#locking-down-weblate

afeurra commented 4 years ago

Thanks to both for your replies. @comradekingu it is a good thing when translating open-source or public project such as websites or wikis, not when translating products for a company, which usually want to keep everything (including repos) private. I do not want guests to see the names of the users (nor the nickname) or the languages. @nijel I already set REGISTRATION_OPEN to 0 and it's working. I'll take a look at LOGIN_REQUIRED_URLS which I wasn't aware of.

afeurra commented 4 years ago

Ok setting

environment:
  WEBLATE_REQUIRE_LOGIN: 1

did what I expected (I'm using the Helm chart with the obvious configurations needed). Now every URL (including /widgets/) requires for authentication. Thanks @nijel for the suggestion and the great work!

github-actions[bot] commented 4 years ago

The issue you have reported seems to be resolved now.