Update of quality checks failed

apourche commented 3 years ago

Describe the bug

If several composats have the same translation key (with the same failed check so):

[ok] the translation from the componant1 has auto repercussion on the component2 translation (very good!);
[ko] but, the failed check linked to the component 2, which no longer applies, remains present;

To Reproduce the bug

Create two components (testsmall1 and testsmall2 ) with the same content :

<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
<file original="file1" source-language="" datatype="plaintext" target-language="en-US">
<body>
  <trans-unit id="unit1">
    <source xml:space="preserve">Test...</source>
    <target xml:space="preserve">Test</target>
  </trans-unit>
</body>
</file>
</xliff>

In testsmall1, correct the translation (addition of '...') to respond to the 'Mismatched full stop' alert :
After this action, the alert disappears in testsmall1 : OK
[ko] In testsmall2, the same character string is corrected auto translated, but the alert 'Mismatched full stop' remains signaled :

Expected behavior

Auto-update (make disappear) the checks alerts when it's necessary.

Server configuration and status

Weblate: 4.3.2
Django: 3.1.3
siphashc: 2.1
Whoosh: 2.7.4
translate-toolkit: 3.2.0
lxml: 4.6.1
Pillow: 8.0.1
bleach: 3.2.1
python-dateutil: 2.8.1
social-auth-core: 3.3.3
social-auth-app-django: 4.0.0
django-crispy-forms: 1.9.2
oauthlib: 3.1.0
django-compressor: 2.4
djangorestframework: 3.12.1
django-filter: 2.4.0
django-appconf: 1.0.4
user-agents: 2.2.0
filelock: 3.0.12
setuptools: 40.8.0
jellyfish: 0.8.2
openpyxl: 3.0.5
celery: 4.4.7
kombu: 4.6.11
translation-finder: 2.5
weblate-language-data: 2020.11
html2text: 2020.1.16
pycairo: 1.16.2
pygobject: 3.30.4
diff-match-patch: 20200713
requests: 2.24.0
django-redis: 4.12.1
hiredis: 1.1.0
sentry_sdk: 0.19.2
Cython: 0.29.21
misaka: 2.1.1
GitPython: 3.1.11
borgbackup: 1.1.14
pyparsing: 2.4.7
Python: 3.7.3
Git: 2.20.1
psycopg2: 2.8.6
psycopg2-binary: 2.8.6
phply: 1.2.5
chardet: 3.0.4
ruamel.yaml: 0.16.12
tesserocr: 2.5.1
akismet: 1.1
boto3: 1.16.12
zeep: 4.0.0
aeidon: 1.7.0
iniparse: 0.5
mysqlclient: 2.0.1
Mercurial: 5.6
git-svn: 2.20.1
git-review: 1.28.0
Redis server: 6.0.9
PostgreSQL server: 13.1
Database backends: django.db.backends.postgresql
Cache backends: default:RedisCache, avatar:FileBasedCache
Email setup: django.core.mail.backends.smtp.EmailBackend: relay-01.kelis.fr
OS encoding: filesystem=utf-8, default=utf-8
Celery: redis://cache:6379/1, redis://cache:6379/1, regular
Platform: Linux 5.4.0-54-generic (x86_64)

Thank you for your answer

github-actions[bot] commented 3 years ago

Thank you for your report, the issue you have reported has just been fixed.

In case you see a problem with the fix, please comment on this issue.
In case you see a similar problem, please open a separate issue.
If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

apourche commented 3 years ago

thanks @nijel !

WeblateOrg / weblate

Update of quality checks failed #5025