search

WeblateOrg / weblate

Web based localization tool with tight version control integration.
https://weblate.org/
GNU General Public License v3.0
4.48k stars 993 forks source link

gitlab webhooks no longer working #5032

Closed ReneBoehm closed 3 years ago

ReneBoehm commented 3 years ago

Describe the issue

We are using weblate in a dockerized environment and since we've upgraded from version 3.x to 4.3 out gitlab hooks are no longer working. When I refresh the repo in the GUI it's working but the hooks are not. We are using PO files with weblate POT extension.

I already tried

To Reproduce

Expected behavior

the project will be updated

Screenshots

If applicable, add screenshots to help explain your problem. image

Server configuration and status

Weblate deploy checks

docker-compose exec --user weblate weblate weblate check --deploy doesn't return, so here are the log entries image

Exception traceback

Additional context

github-actions[bot] commented 3 years ago

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger. In case your question is already answered, making a donation is the right way to say thank you!

nijel commented 3 years ago

The problem is that you request /hooks/gitlab which redirects to /hooks/gitlab/, but the redirection leads to GET being used instead of POST. It seems to be the nginx causing redirection, it might be related to https://github.com/WeblateOrg/docker/pull/857, can you try upgrading your container?

ReneBoehm commented 3 years ago

After the update of all images and the restart, the issue still exists.

ReneBoehm commented 3 years ago

reg. the trailing slash...it doesn't work in both cases, with or without trailing slash

ReneBoehm commented 3 years ago

Ok, I've used the recommendation from WeblateOrg/docker#857 and mounted a patched default.tpl file, where the second server config is removed. Now the hooks are working again.

nijel commented 3 years ago

The fix is part of newer container, upgrade should resolve that without need for manual patching (I've already mentioned this in https://github.com/WeblateOrg/weblate/issues/5032#issuecomment-744455690).

ReneBoehm commented 3 years ago

I've seen that but it didn't solve the issue for me. See my comment above (https://github.com/WeblateOrg/weblate/issues/5032#issuecomment-745404400). Did a docker-compose pull, images got downloaded and the stack has been restarted. Problem still existed. But I can try again.

ReneBoehm commented 3 years ago

OK, did the update again and it downloaded a new image. Now the issue is solved using the defaults. Don't know what image got downloaded yesterday when I've tried that recommendation.

github-actions[bot] commented 3 years ago

The issue you have reported is resolved now. If you don’t feel it’s right, please follow it’s labels to get a clue and take further steps.