Weble / ZohoBooksApi

40 stars 42 forks source link

BankTransactions module #120

Open joopvanduin opened 1 month ago

joopvanduin commented 1 month ago

Thank you for the great library!

I have found 2 problems while using the BankTransactions module

1) Changed returnvalue of function

public function match($id, $data, $params = []) { $data = $this->client->post($this->getUrl() . '/uncategorized/' . $id . '/match', $data, $params); // Joop: 1-10-2024 Changed returnvalue to $data, it was $data['transactions_to_be_matched'], which doesn't exist return $data; }

2) Added function:

// Joop. 29-09-2024. Otherwise banktransaction_id would be used
public function getApiKeyName()
{
    return "transaction_id";
}

All the best Joop

Skullbock commented 1 month ago

Thanks! Can you send a Pull Request with your proposed changes?