Weble / ZohoBooksApi

40 stars 39 forks source link

basecurrencyadjustment error from Zoho #27

Closed xrobau closed 3 years ago

xrobau commented 4 years ago

This may be expected? But since I'm testing all of them...

2019-11-24 21:07:22] local.ERROR: Response from Zoho is not success. Message: Invalid URL Passed {"exception":"[object] (Webleit\\ZohoBooksApi\\Exceptions\\ErrorResponseException(code: 0): Response from Zoho is not success. Message: Invalid URL Passed at /root/billing/src/scrooge/vendor/webleit/zohobooksapi/src/Client.php:327)
[stacktrace]
#0 /root/billing/src/scrooge/vendor/webleit/zohobooksapi/src/Client.php(138): Webleit\\ZohoBooksApi\\Client->processResult()
#1 /root/billing/src/scrooge/vendor/webleit/zohobooksapi/src/Modules/Module.php(41): Webleit\\ZohoBooksApi\\Client->getList()
#2 /root/billing/src/scrooge/test.php(34): Webleit\\ZohoBooksApi\\Modules\\Module->getList()
#3 {main}
"}

   Webleit\ZohoBooksApi\Exceptions\ErrorResponseException  : Response from Zoho is not success. Message: Invalid URL Passed
Skullbock commented 4 years ago

It seems the url we construct is not correct, can you tell me what url is built when calling it? You can print it out at Client line 327

xrobau commented 4 years ago

I seriously have drunk half a bottle of scotch to try to numb the pain of dealing with Zoho all day. On the upside, I'm now at level 10 on the battle tower in Pokemon Sword.

If I don't provide useful information tomorrow, remind me.

https://m.facebook.com/story.php?story_fbid=10157536636492752&id=522827751

On Mon, 25 Nov 2019, 8:10 pm Daniele Rosario, notifications@github.com wrote:

It seems the url we construct is not correct, can you tell me what url is built when calling it? You can print it out at Client line 327

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AADPYRSAZODXBK7OW43OEM3QVOQB3A5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFB3BCI#issuecomment-558084233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPYRRO5APGTG6HLHFQG3TQVOQB3ANCNFSM4JRA7Q3A .

Skullbock commented 4 years ago

lol

On Mon, Nov 25, 2019 at 11:26 AM Rob Thomas notifications@github.com wrote:

I seriously have drunk half a bottle of scotch to try to numb the pain of dealing with Zoho all day. On the upside, I'm now at level 10 on the battle tower in Pokemon Sword.

If I don't provide useful information tomorrow, remind me.

https://m.facebook.com/story.php?story_fbid=10157536636492752&id=522827751

On Mon, 25 Nov 2019, 8:10 pm Daniele Rosario, notifications@github.com wrote:

It seems the url we construct is not correct, can you tell me what url is built when calling it? You can print it out at Client line 327

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AADPYRSAZODXBK7OW43OEM3QVOQB3A5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFB3BCI#issuecomment-558084233 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AADPYRRO5APGTG6HLHFQG3TQVOQB3ANCNFSM4JRA7Q3A

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AAINRU5IBPXXKGVIJNHZOZ3QVOR5VA5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFB4TYI#issuecomment-558090721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU5CHI7CR7B44G7CXQLQVOR5VANCNFSM4JRA7Q3A .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

Skullbock commented 4 years ago

reminder :P

xrobau commented 4 years ago

Dammit. I was meant to look into this today, but got hung up on all the rest of the Zoho insanity.

I'll be caring about currencies again soon (I can't set a currency for a line item, but I CAN set an exchange rate. WHY???) so I'll brain about this again soon.

Leave it open unless you feel like a night of drinking heavily after reverse engineering their errors.

xrobau commented 4 years ago

A message I posted in our slack today:

So today I discovered that the Zoho error 'Please ensure that the cf_service_location_id has less than 100 characters.' actually means 'One of the other fields you are using, but IS NOT THE FIELD I JUST TOLD YOU ABOUT, has been set to the wrong type'

Skullbock commented 4 years ago

Yeah.... and let me tell you: just wait to deal with the zoho crm apis...

And as another curious stuff, i also managed to get access to the zoho backstage apis, which are not yet released to the public, and oh boy they are strange... :P

On Wed, Nov 27, 2019 at 9:44 AM Rob Thomas notifications@github.com wrote:

A message I posted in our slack today:

So today I discovered that the Zoho error 'Please ensure that the cf_service_location_id has less than 100 characters.' actually means 'One of the other fields you are using, but IS NOT THE FIELD I JUST TOLD YOU ABOUT, has been set to the wrong type'

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AAINRU5XZEO7AGMUIBHCMTTQVYXONA5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIXY4Q#issuecomment-558988402, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU3DSKQNZJFPHABUQGLQVYXONANCNFSM4JRA7Q3A .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

xrobau commented 4 years ago

We do deal with them. I've wrapped their PHP SDK in something that handles their bullshit crap of randomly crapping out on token renewals. We should switch to your SDK but that's going to be a week's project ... No. I say a 'a week' when I am making the assumption that their API isn't full of cancer and herpes, and we both know that's not the case.... So, that's 3 weeks project.

THIS project of 'Creating Invoices for our stuff' has taken 3 weeks so far, and that includes 8 PRs so far of THEM being wrong.

xrobau commented 4 years ago

https://help.zoho.com/portal/community/topic/bug-in-php-sdk

Skullbock commented 4 years ago

Yeah, the PHP developers in their team seems a bit.... inexperienced

Daniele

On Wed, Nov 27, 2019 at 11:58 AM Rob Thomas notifications@github.com wrote:

https://help.zoho.com/portal/community/topic/bug-in-php-sdk

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AAINRUYET4H7MSVWJQ4X4ATQVZHF3A5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJEBGA#issuecomment-559038616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU6H6C4EEYVEHX5XGFLQVZHF3ANCNFSM4JRA7Q3A .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

xrobau commented 4 years ago

It's not just their PHP developers. This was a bug in their entire sdk - they patched it everywhere, and never admitted to it.

https://github.com/zoho/zcrm-python-sdk/commit/299630a7261980e354470c7cefba5fc96301d23f

'Change in API response', and it has been the same forever. This has, literally, been a bug forever and they never noticed.

Yes. I'm having scotch again. How did you notice? Was it the ranting? It was the ranting, wasn't it.

Skullbock commented 4 years ago

Would've never guessed unless you told me :P

On Wed, Nov 27, 2019 at 12:22 PM Rob Thomas notifications@github.com wrote:

It's not just their PHP developers. This was a bug in their entire sdk

  • they patched it everywhere, and never admitted to it.

zoho/zcrm-python-sdk@299630a https://github.com/zoho/zcrm-python-sdk/commit/299630a7261980e354470c7cefba5fc96301d23f

'Change in API response', and it has been the same forever. This has, literally, been a bug forever and they never noticed.

Yes. I'm having scotch again. How did you notice? Was it the ranting? It was the ranting, wasn't it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AAINRUY4HWTDUCXMNKPSXILQVZJ6ZA5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJGCDQ#issuecomment-559046926, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU4ZKNTDHKXJCBKTV3DQVZJ6ZANCNFSM4JRA7Q3A .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

xrobau commented 4 years ago

https://twitter.com/xrobau/status/1199644793569083393

I'm going to bed now.

Skullbock commented 4 years ago

Lol.

Got around using 3CX with it. I was lucky enough

Il giorno mer 27 nov 2019 alle 12:35 Rob Thomas notifications@github.com ha scritto:

https://twitter.com/xrobau/status/1199644793569083393

I'm going to bed now.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/27?email_source=notifications&email_token=AAINRUY7C5ATMSMRMGJQINLQVZLRHA5CNFSM4JRA7Q3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJHDGA#issuecomment-559051160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU4KO26BQLQXWBD27XLQVZLRHANCNFSM4JRA7Q3A .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

Skullbock commented 4 years ago

Hey @xrobau Just to make you cry even more.

I was registering a oauth2 token with zoho and i noticed that urls with "-" in the hostname produced an error. Thinking of a UI bug i reported it to them.

Reply:

We are sorry for the hassle.
​
As of now, hyphens "-" are not allowed in client domain value. We don't consider domain values and consider only redirect url for web-based client oauth process. 
The domain value matters only for jsdomain based clients. So you can remove hyphen in your domain value and register. 
We will be supporting this in near future.

WTF????

xrobau commented 3 years ago

Being that this has been open for almost a year now, and I haven't hit this bug again, I think we can consider this closed.

I also did, recently see an update from them when they DID realise that '-' in a domain is a valid character. Maybe someone pointed them towards https://tools.ietf.org/html/rfc5890 where xn-- is used as the prefix of I18n domains!

Skullbock commented 3 years ago

yeah, they start with strange assumptions sometimes...