Incorrect resource key for CustomerPayments

[bluec]

Resource key for Customer Payments should be "customerpayments" for getList() method to work when creating the collection.

This is a regression introduced in #37 - the correct fix is detailed in the comments of #29 but was not applied correctly.

[Skullbock]

You were right. We fixed the get() call and broke the getList() call. Now it should be ok ;) Thanks!

[bluec]

Interesting fix... their API seems incredibly inconsistent!

[Skullbock]

It IS incredibly inconsistent. And wait until you check their CRM api.... anyway, this is the best way i think i can fix it

Daniele

On Thu, Jan 23, 2020 at 10:11 AM Chris N notifications@github.com wrote:

Interesting fix... their API seems incredibly inconsistent!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/42?email_source=notifications&email_token=AAINRU3ET74WGT7UPL4WGATQ7FNLDA5CNFSM4KKS5Y6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJWVSWY#issuecomment-577591643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRUZ6UZFJ7Y5VMFXQ7E3Q7FNLDANCNFSM4KKS5Y6A .

-- Daniele Rosario CTO

Weble.it http://weble.it/ Via Enrico Fermi 265 36100 Vicenza +39 0444 130094 <+390444130094> +39 328 3017134 <+393283017134>

[bluec]

Thanks, it's great that your library takes care of these inconsistencies so at least we have a consistent API to work with inside PHP. Seems every resource in their API uses a different way to pluralise or snake case the identifiers!

[Skullbock]

Yeah, it's exactly like that. I have the impression that many people work on the apis, and they don't have a clear code style guide to follow. Moreover they apply breaking changes often without versioning the apis...

On Thu, Jan 23, 2020 at 10:32 AM Chris N notifications@github.com wrote:

Thanks, it's great that your library takes care of these inconsistencies so at least we have a consistent API to work with inside PHP. Seems every resource in their API uses a different way to pluralise or snake case the identifiers!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/42?email_source=notifications&email_token=AAINRU7446OV43NV43AYXSTQ7FP2RA5CNFSM4KKS5Y6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJWXSTI#issuecomment-577599821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRUZRHISPYFHETADKTGTQ7FP2RANCNFSM4KKS5Y6A .

-- Daniele Rosario CTO

Weble.it http://weble.it/ Via Enrico Fermi 265 36100 Vicenza +39 0444 130094 <+390444130094> +39 328 3017134 <+393283017134>

[bluec]

Just testing this. Seems we may also need to use getResourceItemKey() in the create and update methods of Module.php?

[Skullbock]

Hi Chris, i made the change but i'm waiting to commit because the trial version i'm using for the api tests has expired and i'm waiting for zoho to renew it

On Thu, Jan 23, 2020 at 5:39 PM Chris N notifications@github.com wrote:

Just testing this. Seems we may also need to use getResourceItemKey() in the create and update methods of Module.php?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Weble/ZohoBooksApi/issues/42?email_source=notifications&email_token=AAINRUYCOYPPSMWDJ6QXMBDQ7HB43A5CNFSM4KKS5Y6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJX7W2Y#issuecomment-577764203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINRU2E57FNXUKN7WJ4LTLQ7HB43ANCNFSM4KKS5Y6A .

-- Daniele Rosario CTO

Weble.it http://weble.it/ Via Enrico Fermi 265 36100 Vicenza +39 0444 130094 <+390444130094> +39 328 3017134 <+393283017134>

[Skullbock]

Fixed. Took me 1 min to change the code and 15 min phone call to explain to zoho why i wanted to free edition of zoho books to test this...