Weble / ZohoClient

11 stars 7 forks source link

Fixes #11 extend Asad class to set expires correctly #12

Closed tm1000 closed 3 years ago

tm1000 commented 3 years ago

Heres my implementation (with a test!) to make sure we are setting expires correctly (if https://github.com/asadku34/oauth2-zoho/pull/1 isn't committed)

The only thing I wonder is since I had to extend two of Asad classes should we just drop it (if he doesnt update) and just maintain our own (just putting those classes in here the licenses are compatible)

Skullbock commented 3 years ago

Merged. If in a couple of months he's yet to update it, we'll just roll out our own and drop the dependency