search

Webonaute / DoctrineFixturesGeneratorBundle

Generate Fixture from your existing data in your database. You can specify the Entity name and the IDs you want to import in your fixture.
63 stars 47 forks source link

Add Order possibility #6

Closed ioniks closed 9 years ago

ioniks commented 9 years ago

And fix problem with null value (on datetime for example)

Webonaute commented 9 years ago

Thank I will review the change as most of the change not complain on the code format I use.

Webonaute commented 9 years ago

Change has been added to master and tagged v1.2.1

ioniks commented 9 years ago

Why My code is on your git without mentionned my travel or merge with my merge request ? (you have copied it intregaly ! and made just few change )

Webonaute commented 9 years ago

Like I said in the previous comment, you were changing some stuff I cannot merge. Documentation link, Code format. You did not add correct order option validation so I added it. I thank you for your contribution but I could not just merge it like that. I hop you understand.

ioniks commented 9 years ago

You can say change for merge before add my code without notifing me ..... So i don't understand why you do it without say to me change what to do before merge

Webonaute commented 9 years ago

sorry. I am not very familiar with the github workflow and for the small amount of time I have to maintain this, and a few line of code to implement, I just see it faster to just put the code and not have to do some back and forth to integrate the functionality. I have no bad intention here.

Webonaute commented 9 years ago

I added your contribution to the readme file. Is it ok for you?

ioniks commented 9 years ago

yes thanks