Webperf-se / webperf_core

webperf-core is an open-source testing suite tailored to help you improve your digital presence in areas like web performance, security and accessibility to email best practice using many small improvements.
https://webperf.se/articles/webperf-core/
MIT License
19 stars 31 forks source link

Test Improvement - Software - Matomo #482

Open cockroacher opened 6 months ago

cockroacher commented 6 months ago

Feature/improvement

Code was commented out, let's see if we want to implement it in one way or an other.

    # TODO: THIS MUST BE LOOKED AT FROM A 'COMPUTER BREACH' ARGUMENT,
    # if item['name'] == 'matomo':
    #     a = 1
    # THERE IS NO REFERENCE TO THIS SO IT COULD (WRONGLY) BE ARGUED THAT YOU ARE TRYING TO HACK
    #     matomo = {}
    #     matomo['name'] = 'Matomo'
    #     matomo['url'] = item['url']
    #     matomo_version = 'Matomo'

    #     # matomo_o = urlparse(item['url'])
    #     # matomo_hostname = matomo_o.hostname
    #     # matomo_url = '{0}://{1}/CHANGELOG.md'.format(
    #     #     matomo_o.scheme, matomo_hostname)
    #     # matomo_changelog_url_regex = r"(?P<url>.*)\/(matomo|piwik).(js|php)"
    #     # matches = re.finditer(
    #     #     matomo_changelog_url_regex, item['url'], re.MULTILINE)
    #     # for matchNum, match in enumerate(matches, start=1):
    #     #     matomo_url = match.group('url') + '/CHANGELOG.md'
    #     #     matomo_content = httpRequestGetContent(matomo_url)
    #     #     matomo_regex = r"## Matomo (?P<version>[\.0-9]+)"
    #     #     matches = re.finditer(
    #     #         matomo_regex, matomo_content, re.MULTILINE)
    #     #     for matchNum, match in enumerate(matches, start=1):
    #     #         matomo_version = match.group('version')
    #     #         matomo['version'] = matomo_version
    #     #         break
cockroacher commented 6 months ago
        # TODO: handle matomo like software rules where version = '>=4.x'.
        # TODO: handle matomo like software rules where version = '>4.x'.
        # TODO: handle matomo like software rules where version = '<5.x'.
        # TODO: handle matomo like software rules where version = '=4.x'.