Image orientation not being honoured for image

Webreaper / Damselfly

Damselfly is a server-based Photograph Management app. The goal of Damselfly is to index an extremely large collection of images, and allow easy search and retrieval of those images, using metadata such as the IPTC keyword tags, as well as the folder and file names. Damselfly includes support for object/face detection.

GNU General Public License v3.0

1.4k stars 75 forks source link

Image orientation not being honoured for image #530

Open Webreaper opened 2 months ago

Webreaper commented 2 months ago

Per @marijnv2000 : File is too big to attach here.. See google drive link: https://drive.google.com/file/d/1Tz6MqP_AWPCO5x7Yc1AC8eXbhLmwNLR6/view?usp=sharing

exiftool shows "Rotate 270 CW". Local image viewers open it up with the correct orientation, damselfly shows it sideways like this:

Webreaper commented 2 months ago

Looks like a SkiaSharp bug. I've reported it here: https://github.com/mono/SkiaSharp/issues/2850

Webreaper commented 2 months ago

I''ve put in a temporary fix, which should solve your issue. @marijnv2000 can you pull webreaper/damselfly:dev and see if it solves it?

marijnv2000 commented 2 months ago

@Webreaper sorry, took a while for me to get back to this. Thanks for looking into this.

I've changed to dev and it still doesn't rotate the image, neither in the thumbnail or when viewing the image. It does look to have solved the stretching issue for the thumbnail however, it now looks like this:

By the way, I'm happy to wait for the SkiaSharp issue to be fixed.

Webreaper commented 2 months ago

Did you refresh the thumbnails via the context menu? They won't be regenerated unless you do. It works fine for me.

marijnv2000 commented 2 months ago

Yes, I did. Twice now :) Same result in the browser and the app, which I guess is expected, but still. Not rotated

Webreaper commented 2 months ago

One other thing to try is pressing shift+refresh in the browser. It could be browser caching.

marijnv2000 commented 2 months ago

Tried clearing cookies and site data for the domain, tried force refresh, tried private mode, tried a different browser that had never opened Damselfly before, and get the same result on all..

Webreaper commented 2 months ago

Dammit. Weird, wonder how it works for me?

marijnv2000 commented 2 months ago

Weird indeed.. Any way to verify we're running the same code? I pulled the dev tag and saw some changes (notably the + on folder icons letting me expand/collapse them) so I assumed it worked correctly.

Webreaper commented 2 months ago

Definitely running the same code. I always run dev.

Possibly an OS thing, I haven't tried it on linux.