Open jzhu01 opened 7 years ago
Thank you for the review Jen. I appreciate you taking the time and going into detail, It means a lot.
I critiqued myself on the following points, if you have a short comment that would be great:
Thanks again Jen.
Of course! I'll address each one of these down below:
I did not include Font Awesome or a favicon (I finished the project, then proceeded to finish Unit 8, only to discover the rest of unit 8 was supposed to be applied to the project) So this is true, I suggest adding these two the project if you have some extra time. While they're not critical, it's good practice with importing fonts, and learning what the favicon is.
I have multiple media queries in order to work in a more structured manner. Is this the best practice? I think it's up to preference. Personally, I prefer one large media query per screen size, with the stylings split into sections. But if you find that your way is easier for you to understand, with the right documentation you should be fine.
I have desperately tried to make my code DRY and re-use code segments. I feel It is easy to code the site, but hard to produce clean and organized code. Am I on the right path here? Yes! You are very much so on the right path. Removing repetition from the code is always a good rule of thumb.
I am unsure of my html semantic's, if I have applied them correctly. I'm not entirely sure of what you mean here. If you're referring to special characters for &, you can use those or these symbols. Maybe you want to elaborate in another comment?
One problem can have multiple solutions. Best practice is important to me. If you see any code that should be done differently, please let me know. Of course! I highlighted the pieces I found important, but overall your execution of the project was great. :smile:
Neat job with this project! I liked how you added your own design bits to the code - such as the your own font-family and hover features (I really liked the scaling effect!). In terms of improvement, I suggest removing the max-width on .wrapper.
If you're looking for a challenge, I'd recommend trying to switch this page to implement bootstrap. Here's a link to get you started: https://www.w3schools.com/bootstrap/. Keep up the fantastic work! :D