WebsiteBeaver / CordovaCall

Cordova CallKit & ConnectionService plugin for iOS/Android that displays the native call UI for VOIP apps
MIT License
196 stars 91 forks source link

VoIP app is missing from stock Contacts app on iOS #39

Closed rmanasyan closed 6 years ago

rmanasyan commented 6 years ago

Hi,

looks like this plugin should support this feature when voip app can be opened (called via) from ios contacts but it does not work for me...

please see how WhatsApp is added to the list on this screenshot as example img_0432

is this something that can be done by updating supportedHandleTypes with CXHandleTypePhoneNumber or I'm just missing some configuration to make it work?

thank you!

D-Marc1 commented 6 years ago

Maybe I'm misunderstanding you, but your desired behavior should work. Check out this section https://github.com/WebsiteBeaver/CordovaCall#make-a-call-from-recents.

rmanasyan commented 6 years ago

it's not exactly about making a call from Recents, the scenario is: open Phone book on iOS, select any contact, get my voip app listed in the action sheet along with WhatsApp and other callkit enabled apps

can you please confirm if this feature is supported in this plugin?

thank you

ps: setIncludeInRecents(true) is set

dmarcs commented 6 years ago

Good catch! You're right about using CXHandleTypePhoneNumber. I changed CXHandleTypeGeneric to CXHandleTypePhoneNumber, and now CordovaCall supports calling from contacts in addition to recents. You can either tap and hold the phone or video, and it will force open your app and call the person using your VOIP app. I'm sure you already made the changes to your app, but we appreciate you raising the issue because it will help other app developers in the future.

cordovacall

rmanasyan commented 6 years ago

thanks! it works now with version 1.1.5