search

WebsiteBeaver / capacitor-document-scanner

A Capacitor document scanner plugin for Android and iOS
https://document-scanner.js.org
66 stars 24 forks source link

Multi-language support #18

Open MarvinNorway opened 1 year ago

MarvinNorway commented 1 year ago

Hi @dmarcs, We love this component and would love it even more if there was support for other languages. How can we make this happen? We'd be open for submitting a pull request, but I'd like to hear your thoughts on how you would like this implemented first. Thanks, Marvin

dmarcs commented 1 year ago

You can change language in Xcode settings. If you're talking about changing language once the app is running, I'm not sure since I haven't looked into whether or not it's possible.

MarvinNorway commented 1 year ago

Thanks, will give that a try. Would Xcode also cover Android? My colleague tells me it’s for iOS only.

ameckl commented 1 year ago

Hello @dmarcs! The language of our product is determined build-time, so currently we are not planning to be able to switch languages during runtime. In your opinion what is the best way to be able to apply internationalisation to document-scanner ? We are building both for iOS and Android.

MarvinNorway commented 1 year ago

@dmarcs Is that what you mean? https://stackoverflow.com/questions/25871815/changing-the-development-language-in-xcode

Is there a similar setting for Android?

MarvinNorway commented 1 year ago

@dmarcs We would be happy to provide a pull request if something needs to be changed. We would very strongly prefer having official multi-language support in the app, rather than just adding this in a local fork. Please let me know what you think about that.

dmarcs commented 1 year ago

The document scanner doesn't display words on Android, so you don't need to worry about translating that. I can't remember exactly which Xcode setting, but I got it to work here https://github.com/WebsiteBeaver/react-native-document-scanner-plugin/issues/1.