WebwareForPython / DBUtils

Database connections for multi-threaded environments
MIT License
335 stars 52 forks source link

GitHub Action to lint Python code #28

Closed cclauss closed 3 years ago

cclauss commented 3 years ago

Output: https://github.com/cclauss/DBUtils/actions

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead, these tests are focus on runtime safety and correctness:

Cito commented 3 years ago

Thank you for this proposal. We already check with flake8 using Travis, but I wanted to migrate to GitHub Actions anyway, see #30. Not sure if all of these checks make sense for DBUtils (I see you already deactivated most of them with || true), but I will certainly consider your PR. Maybe we should also run the checks with tox so that the same tests can be executed locally.

cclauss commented 3 years ago

https://docs.github.com/en/actions/guides/building-and-testing-python#running-tests-with-tox

Or

https://github.com/tox-dev/gh-action-tox

cclauss commented 3 years ago

Closed in favor of #31