Commit change in line 138

Wedge-lab / dpclust

Dirichlet Process based methods for subclonal reconstruction of tumours

GNU Affero General Public License v3.0

28 stars 16 forks source link

Commit change in line 138 #24

Closed Avramis closed 1 month ago

Avramis commented 8 months ago

Response to Issue with !is.na #23. Commit change in line 138 in file ./R/SampleMutations.R to return TRUE or FALSE instead of a vector of logical value that can cause the code to break

It would be advisable to look into the rest of the !is.na cases in the code (lines 20, 84, )

christopherwirth commented 1 month ago

Thanks Avraam. This is a smart fix as it returns NA if either:

the whole item (clustering_result$all.assignment.likelihoods) is NA, or
clustering_result$all.assignment.likelihoods has length > 1 but every element of it is NA

Otherwise (i.e. clustering_result$all.assignment.likelihoods can be any length as long as at least one element is NOT NA), it continues into the conditional code.