search

Wedge / wedge

This is the official Wedge repository. Despite the lack of publicity, it's definitely completed and fully working, and used in many websites, e.g. https://lestrades.com. Try it out, it's entirely free, and one of the most innovative 'classic' forum frameworks out there!
https://github.com/Wedge/wedge/
Other
44 stars 12 forks source link

BBCodes are now hardcoded in Subs-BBC again. #58

Closed C3realGuy closed 7 years ago

C3realGuy commented 7 years ago

Still loading bbcodes from plugins from database. Should increase performance.

Nao commented 7 years ago

I don't know if this would increase performance because IIRC the bbc list is cached (at least for the current page) after it's loaded, and these days most database setups can be more efficient than simple file caching. Still, outside of performance non-issues, I'm mostly interested in not storing PHP code inside the database. ;) Is this mergeable without any issues, btw..?

C3realGuy commented 7 years ago

Only tried it on my local test install but didn't notice any issues. BBC list is maybe cached (but only from the database? So same query, mysql server just gives back the list without going through the database once again?), but the performance increase comes from not connecting to the database and not iterating over the bbcode list to replace {{some_lang_string}}. Don't think this is noticeable, but should be better.

Nao commented 7 years ago

I'm gonna merge to make your life easier. ;) There are still spacinazis to fix though!

Nao commented 7 years ago

(And would be good if someone benchmarked both versions!)

Nao commented 7 years ago

I was doing the spacinazi thing when it hit me... you're using php7-specific array representations lol. I'll need to fix those as well.

Nao commented 7 years ago

Or maybe I could use loadSource to change those on the fly depending on the php version...