Fix failing tests - Githubissues

peteretelej commented 6 years ago

Corrects invalid test values at caddyhttp/errors/errors_test.go: test assumed working directory and log print values. Change does not delete test, only updates it to will correct check.

Adds tests deps to vendor/

gopkg.in/mcuadros/go-syslog.v2 required by caddyhttp/httpserver/logger_test.go
golang.org/x/net/websocket required by caddyhttp/proxy/proxy_test.go

1. What does this change do, exactly?

Fixes failing go test ./... by correcting a bad test value and adding test dependencies to vendor/

2. Please link to the relevant issues.

N/A

3. Which documentation changes (if any) need to be made because of this PR?

None.

4. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I am willing to help maintain this change if there are issues with it later

lol768 commented 6 years ago

Is this test failing upstream too?

kashike commented 6 years ago

https://github.com/WedgeServer/wedge/blob/master/caddyhttp/errors/errors.go#L131-L135

lol768 commented 6 years ago

Cheers kashike.

WedgeServer / wedge

Fix failing tests #7

1. What does this change do, exactly?

2. Please link to the relevant issues.

3. Which documentation changes (if any) need to be made because of this PR?

4. Checklist