WeebDev / Commando

[DEPRECATED] ⚫ Commando Discord bot built on discord.js-commando.
https://github.com/Gawdl3y/discord.js-commando
MIT License
77 stars 63 forks source link

Add ?translate #50

Closed kurisubrooks closed 7 years ago

TeeSeal commented 7 years ago

Since you added it to the util folder, might as well have just given it the util group as well, and not register a new command group o w o

Also, args.query will only be 1 word. I'd reorder them like: to, from, query and give query infinite: true

kurisubrooks commented 7 years ago

Ah, @vzwGrey suggested I add it to it's own group, so I was just following orders.

Also, from is optional, and i'd like it to stay that way, so we put to and from at the end...

novara754 commented 7 years ago

Sorry, I meant if you did leave it in its own folder you'd have to register the translate group, but since you moved it to util it should just have the 'util' group instead of its own 'translate' group.

TeeSeal commented 7 years ago

Well, if Grey said so I will shut up.

But Commando's arg sys is kinda weird now that I checked. Gonna read up in the docs. :+1:

kurisubrooks commented 7 years ago

Oh, so, should I remove the custom type or....?

TeeSeal commented 7 years ago

group: 'util' and ~['translate', 'Translate]~

novara754 commented 7 years ago

Yeah, just use 'util' if you're gonna leave it in the util folder, and remove the ['translate', 'Translate'] group from the registry.

kurisubrooks commented 7 years ago

🙌

iCrawl commented 7 years ago

Hmmmmmm

jithatsonei commented 7 years ago

daily reminder crawl makes you rebase because he secretly doesnt know how to cuck