WeebWare / Ranobe-Honyaku

A novel translation platform.
MIT License
8 stars 2 forks source link

Server sqlalchemy #5

Closed cloudiirain closed 7 years ago

cloudiirain commented 7 years ago

Rebased as per @ccubed's request. A more detailed history of individual commits can be found here.

Summary of Changes:

Dependencies:

Fuyukai commented 7 years ago

Jesus fucking christ that's a terrible reasoning to switch away from Flask-SQLAlchemy.

If you have a circular import in that case, fix your design, don't switch away from a library.

Oh, and db.Model is a declarative base.

ghost commented 7 years ago

What's the point in rebasing while a PR is still under development? You rebase it once it's been approved prior to accepting...

cloudiirain commented 7 years ago

Commit is rebased. PR description is updated with a better summary.

In addition, I've addressed/fixed the suggestions by @SunDwarf and @ccubed.

cloudiirain commented 7 years ago

Made all changes recommended by @zelya and updated PR.