Closed Sega-Zero closed 7 years ago
I think the enums should of remained without an argument label for the associated values. I think the enum is descriptive enough, and the documentation that Apple gives doesn't have an argument label on associated values: https://developer.apple.com/library/prerelease/content/documentation/Swift/Conceptual/Swift_Programming_Language/Enumerations.html
I thought I removed all the associated value labels, where did I missed it?
Oh god, nevermind that. They are removed on the enums. I mistook CerealDecoder.____
as an enum case. In any case, I think things like CerealDecoder.rootCerealItemsWithData
should actually be CerealDecoder.rootCerealItems(with data: Data)
Agree. Renaming will take some extra time :)
Should I rename CerealEncoder's dataWithRootItem(_ root: ItemType) throws -> Data {
to
data(with rootItem: ItemType) throws -> Data {
?
Yeah, and all the other dataWith______
calls please :)
Had to rename to data(withRoot:)
, because without root
in parameter name it becomes unclear what kind of value the function expects.
Is there anything else? :)
Hope you guys merge this PR someday =) If no more changes required, please release pod version for swift-2, swift-2.3 and the latest swift-3
Will-do. I'll look again today -- eddie's on vacation :)
Full swift 3 support based on Cereal 2.0, finally :) depends on #25