Open Gallaecio opened 6 years ago
@Gallaecio Are these known to be compatible? Seems like we'll get ourselves into a pickle in the future,
You can never assure that a dev-master will work. I believe that is the point. The thing is, if someone is using the dev-master version of phpstan, hence risking phpstan not working fine itself, shouldn't we allow them to install the dev-master version of phpstan-laravel and, if there is any issue, report it here so that it can be fixed early?
We need to test on Travis
PHPStan 0.10 was released https://github.com/phpstan/phpstan/releases/tag/0.10 :smile:
We need additional changes:
PHP Fatal error: Declaration of Weebly\PHPStan\Laravel\BuilderMethodExtension::setBroker(PHPStan\Broker\Broker $broker)
must be compatible with PHPStan\Reflection\BrokerAwareExtension::setBroker(PHPStan\Broker\Broker $broker):
void in .../vendor/weebly/phpstan-laravel/src/BuilderMethodExtension.php on line 15
https://github.com/Weebly/phpstan-laravel/blob/master/src/BuilderMethodExtension.php#L52 https://github.com/phpstan/phpstan/blob/master/src/Reflection/BrokerAwareExtension.php#L10
@Gallaecio Can you please take a took into @szepeviktor's comment? So we can merge it, I can't wait to work with Laravel and PHPStan 0.10 :smile:
I consider what @szepeviktor reports beyond the scope of this change. The goal of this change is to allow the installation, even if it does not actually work.
Fixed in #19
Fixes #15