Support phpstan’s dev-master version

Weebly / phpstan-laravel

Laravel plugins for PHPStan

BSD 2-Clause "Simplified" License

51 stars 22 forks source link

Support phpstan’s dev-master version #16

Open Gallaecio opened 6 years ago

Gallaecio commented 6 years ago

Fixes #15

twistor commented 6 years ago

@Gallaecio Are these known to be compatible? Seems like we'll get ourselves into a pickle in the future,

Gallaecio commented 6 years ago

You can never assure that a dev-master will work. I believe that is the point. The thing is, if someone is using the dev-master version of phpstan, hence risking phpstan not working fine itself, shouldn't we allow them to install the dev-master version of phpstan-laravel and, if there is any issue, report it here so that it can be fixed early?

szepeviktor commented 6 years ago

We need to test on Travis

with phpstan dev-master (allow-fail)
and with phpstan latest

carusogabriel commented 6 years ago

PHPStan 0.10 was released https://github.com/phpstan/phpstan/releases/tag/0.10 :smile:

szepeviktor commented 6 years ago

We need additional changes:

PHP Fatal error:  Declaration of Weebly\PHPStan\Laravel\BuilderMethodExtension::setBroker(PHPStan\Broker\Broker $broker) 
must be compatible with PHPStan\Reflection\BrokerAwareExtension::setBroker(PHPStan\Broker\Broker $broker): 
void in .../vendor/weebly/phpstan-laravel/src/BuilderMethodExtension.php on line 15

https://github.com/Weebly/phpstan-laravel/blob/master/src/BuilderMethodExtension.php#L52 https://github.com/phpstan/phpstan/blob/master/src/Reflection/BrokerAwareExtension.php#L10

carusogabriel commented 6 years ago

@Gallaecio Can you please take a took into @szepeviktor's comment? So we can merge it, I can't wait to work with Laravel and PHPStan 0.10 :smile:

Gallaecio commented 6 years ago

I consider what @szepeviktor reports beyond the scope of this change. The goal of this change is to allow the installation, even if it does not actually work.

szepeviktor commented 6 years ago

Fixed in #19