search

Weebly / phpstan-laravel

Laravel plugins for PHPStan
BSD 2-Clause "Simplified" License
51 stars 22 forks source link

Support for Laravel 5.7 #23

Closed j6s closed 4 years ago

j6s commented 6 years ago

This PR adds support for laravel 5.7 by simply bumping the requirement in composer.json.

pablorsk commented 5 years ago

great PR...

j6s commented 5 years ago

Honestly - I cannot figure out why the tests fail in PHP 7.1 and 7.2 - there seems to be something wrong with this PR.

Tlapi commented 5 years ago

What about upgrading phpstan?

-- didn't help

JeroenVanOort commented 5 years ago

I think I've got this down to https://github.com/laravel/framework/pull/24526/files#diff-668bf88875179a4d26f558794a587abfR510 . Don't know if the problem is in Laravel or phpstan, though.

Will look into this again soon.

pablorsk commented 5 years ago

while @j6s try to solve the problem with laravel 5.7.*, you can add this to your composer.json

    "require-dev": {
        "weebly/phpstan-laravel": "dev-feature/laravel-57"
    },
    "repositories": [
        {
            "type": "git",
            "url": "git@github.com:j6s/phpstan-laravel.git"
        }
    ],