search

Weebly / phpstan-laravel

Laravel plugins for PHPStan
BSD 2-Clause "Simplified" License
51 stars 22 forks source link

Require PHP 7 and add patch version to PHPStan #8

Closed carusogabriel closed 6 years ago

carusogabriel commented 6 years ago

I'd like to suggest that we add PHP 7 requirement to our composer.json, as well add the patch version for PHPStan as is has several fixes :+1:

mr-feek commented 6 years ago

The version that phpstan requires is ~7.1 https://github.com/phpstan/phpstan/blob/master/composer.json#L16 I suggest we use the same here.

twistor commented 6 years ago

I don't understand the point of these changes. You can use whatever compatible version you want. Are there specific related bug fixes? If not, I'd rather leave it as open as possible.

Also, 0.9.2 requires 7.0 https://packagist.org/packages/phpstan/phpstan#0.9.2

Also, what's the point of setting a PHP requirement if phpstan already has one? It's just something more to keep updated.