search

WeeeHung / pe

0 stars 0 forks source link

Message Shown does not Represent the situation well enough #2

Open WeeeHung opened 8 months ago

WeeeHung commented 8 months ago

When Student of index 1 already has the TG of T01, i executed the editStu command to change its TG to T01.

The expected result should be that it is an invalid change in TG as no fields are being edited. But the result shows that the student is being edited (where it should have thrown a warning or error, to inform users that no fields provided are different)

image.png

nus-se-script commented 7 months ago

Team's Response

Thanks for the feedback! However, we believe this is NotInScope because the issue does not impact that the user much (the edited student is simply the same as the original) and the alternative is to check all the fields which introduces additional code and overhead.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]