Weeks-UNC / shapemapper2

Public repository for ShapeMapper 2 releases
Other
29 stars 16 forks source link

Fastq format bugfix #46

Open Psirving opened 12 months ago

Psirving commented 12 months ago

2 bug fixes:

  1. '+' entry of fastq files were not allowed to have content, despite being valid fastq format, and ShapeMapper2 not caring about this content. Very annoying for SRA file downloads.
  2. --amplicon and --correct-seq used simultaneously produced an error because MutationCounter, MutationParser, and SequenceCorrector components were not given names or associated RNA targets. See issue #31.

Tony or Lucas, can you double check these? We have been using them in Shapemapper 2.1.5 with no issues yet, but untested with 2.2.0.