Closed otobrglez closed 7 years ago
Hey,
Thanks for the contribution.
Regarding your questions:
In tests, you also create GIN index on event. That is impossible to do on JSON-type if you don't specify JSON key for GIN. Should that also be written in README.adoc?
Indexing the events the journal is not needed for the plugin to do its job, because the plugin never queries the journal using that index.
It can however be done optionally if you wants to query the journal for specific events.
And yes, you are correct that it only works for jsonb type and not for the json type.
Why are you using VARCHAR for uuid fields - why not uuid from Postgres?
We wanted to have consistency between the uuid
and writeruud
fields in the journal. The uuid
is generated by the plugin and is indeed a UUID. The writeruuid
comes from akka-persistence and although it is also a uuid, it is types as a string
.
Hey 👋!
There is a typo in main
README.adoc
with three dots...
; perhaps it should not be there? This is a patch that removes this...I also have this two questions; perhaps you can help me with...
1) In tests, you also create
GIN
index onevent
. That is impossible to do on JSON-type if you don't specify JSON key forGIN
. Should that also be written inREADME.adoc
? 2) Why are you usingVARCHAR
foruuid fields
- why notuuid
from Postgres?Hope this helps someone out there, and thanks for your contribution! 👍