search

Wehavecookies56 / Bonfires

Bringing bonfires from Dark Souls to Minecraft
GNU Lesser General Public License v3.0
4 stars 9 forks source link

Nightmare twilight fire attacks patch #43

Closed NightmareTwilight closed 9 months ago

NightmareTwilight commented 9 months ago

Should Fix Issue #42

Wehavecookies56 commented 9 months ago

Oh damn I should've noticed that, not sure why GitHub didn't send me a notification for this either. While this will stop everything setting on fire this will make the coiled sword not light anything on fire either. I should've added an item check in the AttackEntityEvent that was a dumb mistake. Annoyingly in 1.18 attackStrengthTicker will always be 0 when hurtEnemy is called so getAttackStrengthScale never returns 1. I probably should just remove that entirely it was just from merging my changes in 1.20. I've got some changes I need to push anyway so I'll fix this too. Also thanks for letting me know about this.