search

WeiDUorg / weidu

WeiDU is a program used to develop, distribute and install modifications for games based on the Infinity Engine.
http://www.weidu.org
GNU General Public License v2.0
90 stars 20 forks source link

load: load both gemrb paths #164

Closed lynxlynxlynx closed 4 years ago

lynxlynxlynx commented 4 years ago

fix the remainder of #153

This should do it, but I haven't tested. Conceptually it's fine, but I don't know if you treat paths on windows specially or anything like that (in my experience slashes work there too).

lynxlynxlynx commented 4 years ago

Or if you prefer a cleaner, but longer solution, it looks like the Filename module has everything: https://ocaml.org/releases/4.10/htmlman/libref/Filename.html

lynxlynxlynx commented 4 years ago

@FredrikLindgren any preference, other feedback?

I was also not sure if the order is preserved — "shared" should be searched after the specified path.

FredrikLindgren commented 4 years ago

Sorry, I've been a bit preoccupied. The order is fine. Override will be loaded before gemrb_path, which will be loaded before shared.

Implemented in c1e885d683731632e51df2a3c0b6bd89f64682ac. Sorry for taking so long on this.

lynxlynxlynx commented 4 years ago

Don't worry about it, thanks! Can confirm it works as expected. What are your plans for the next release, time-wise?

FredrikLindgren commented 4 years ago

I can offer no time estimate. Development has been fairly dormant lately, and while things have mostly cleared up, now there's a fair backlog of features and bugs I feel I need to sort through.