WeiDUorg / weidu

WeiDU is a program used to develop, distribute and install modifications for games based on the Infinity Engine.
http://www.weidu.org
GNU General Public License v2.0
90 stars 20 forks source link

TP_Add_2DA "already present" check can check file other than target file #165

Closed FredrikLindgren closed 4 years ago

FredrikLindgren commented 4 years ago

http://forums.pocketplane.net/index.php?topic=29937.0

Basically, FILE_CONTAINS_EVALUATED checks the file system before attempting to load the game resource, while the target for Add_2DA is the game resource.

This can be a more general problem, since user-local configurations can change the result of FILE_CONTAINS_EVALUATED independent of how the code author expects the code to work.

FredrikLindgren commented 4 years ago

Fixed in 89e68e962374d3e6894bd6b49da966f3819a6c6b