FJ_CRE_VALIDITY on charbase.cre

WeiDUorg / weidu

WeiDU is a program used to develop, distribute and install modifications for games based on the Infinity Engine.

http://www.weidu.org

GNU General Public License v2.0

87 stars 19 forks source link

FJ_CRE_VALIDITY on charbase.cre #245

Open aquadrizzt opened 3 months ago

aquadrizzt commented 3 months ago

Is there a specific reason for

PATCH_IF ~%SOURCE_RES%~ STRING_EQUAL_CASE charbase BEGIN
    valid = 0
  END ELSE BEGIN

in fj_cre_validity? Changelog says it is at least 14 years old, so I assume it has something to do with PST? I haven't encountered any game breaking bugs from messing with CHARBASE.cre in PSTEE. Some weird behaviors, sure, but no crashes.

(At the very least, could it be changed to not fail silently?)