WeibelLab-Teaching / CSE_218_118_Fa20_Team_SRSLy_Joking

1 stars 0 forks source link

Implement WebRTC #18

Closed tlsharkey closed 3 years ago

siueric0010 commented 4 years ago

Example Code used: https://github.com/Dirvann/mediasoup-sfu-webrtc-video-rooms

siueric0010 commented 3 years ago

webrtc_sfu_experiment is the experiemnt branch for webrtc. I will be using Dirvann's code a lot to implement meeting room functionality with webrtc. I got webRTC to work by using their code, but I will be going through the code and commenting through the entire code to understand how it works and if we really need all of the code.

siueric0010 commented 3 years ago

TODO:

tlsharkey commented 3 years ago

Implemented a bunch of these in the branch for #19 : ticket-19_Avatars. I'm not sure exactly what they all mean, but they may all be done already.

There's a little bug on the branch (about the order in which people join) after my last commit, once I fix that I'll merge it, but the code is stable if you want to look at it.

siueric0010 commented 3 years ago

I see, I also implemented the stuff above in my own branch. I've also added the positioning of videos which took most of my time. I'll check out your code and see what conflicting code I can delete. Lmk when you merge the branch back into main so I can resolve conflicts and push my changes as well.

siueric0010 commented 3 years ago

Also, my changes are not as big as yours, so it won't be as hard to resolve conflicts: #ticket18-updating-streamers