search

WeibelLab / ChronoSense

ChronoSense: a multimodal data capture software for all. OS agnostic, time aware, extensible. Powered by Node.js and Electron.
http://chronosense.ucsd.edu/
GNU General Public License v3.0
3 stars 0 forks source link

New feature - audio monitor #35

Closed stevenrick closed 3 years ago

stevenrick commented 3 years ago

Updates logic flow for constraints and stream handling to now support an audio monitor UI element.

Constraints are now class variables for each Camera

Can start and stop streams as well as change audio source with appropriate error handling

If audio or video are independently turned off the other stream is still available (audio + monitor UI / video + canvas)

stevenrick commented 3 years ago

@riduong this now resolves the issues raised during review, specifically: 1) audioContext canvas is cleared on close (no green remains) 2) video checkbox removed from screen capture due to inability to capture desktop audio without video 3) constraint handling and logic updated to match above changes

stevenrick commented 3 years ago

Good catch @riduong regarding being able to change contexts while recording - I think wrapping all of the UI elements with proper enable/disable behavior should come in a future fix after they all get normalized to proper HTML input fields - for example to fix what you found we should disable the selecter for the audioContext if recording