WeibelLab / ChronoSense

ChronoSense: a multimodal data capture software for all. OS agnostic, time aware, extensible. Powered by Node.js and Electron.
http://chronosense.ucsd.edu/
GNU General Public License v3.0
3 stars 0 forks source link

Deployment bugfix #45

Closed stevenrick closed 2 years ago

stevenrick commented 2 years ago

This PR merges in a number of changes to resolve issues around packaging and deploying ChronoSense across Windows and Mac OS. Specifically it implements usage of path_fix@3.0 in order to resolve some issues with child_process spawning that is different between OS's to resolve #44 - @latest can not be used due to electron not supporting ESM natively.

Other quality of life improvements include changing the default recording directory to the current user's desktop as well as setting the recording directory to always be a timestamp when recording begins. NOTE if for some reason the desktop is not located at the default location a recording error may occur and current error handling does not make this obvious to the user. Created a new PR #46 to address this and implement other error handling.

Replaces all .concat() usage around pathing for the safer path.join() function

Finally includes version bump to v1.5.2 and audits vulnerabilities in npm.