Weiennn / pe

0 stars 0 forks source link

Phone number validation #7

Open Weiennn opened 1 year ago

Weiennn commented 1 year ago

Given the nature of projects, there may be people from different countries you have to work with. Should you accept a greater range of phone numbers, for example, those with different country codes like +66.

image.png

nus-pe-bot commented 1 year ago

Team's Response

image.png

This is valid suggestion, as having country codes for phone numbers would make a lot of sense, but we have specified this behaviour in our UG, and also in the suggested error message. Having this feature is not really a priority and it can be overcome by not having the + in the phone number. In the example provided by the tester, it can just be 6612341234.

Therefore, we would like to classify this as NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: While I do see the point of view of the team. I still believe that blocking the use of "+" could lead to the confusion of the user. For example, a number like 6612341234 might be ambiguous – is the country code +6, +66, or +661? Having the "+" would create a better experience for the user.

In addition, this could also be seen as a type of overzealous input validation as restricting it could hinder the user from using your application to its full potential. Hence, I think that it should be considered a feature flaw with severity.Low instead.

image.png