Weifanwu66 / Weifan-Kailin-MADA-project

0 stars 2 forks source link

Part 3 feedback #2

Open SarBen811 opened 1 year ago

SarBen811 commented 1 year ago

Hi! Good job on your project so far. Couple of things I noticed below, but everything was present and mostly ran well! Grade = 3/3

Notes:

irenecavros commented 1 year ago

First of all, GREAT JOB! The figures you made were all beautiful and I only had one issue in running the actual code you wrote: Here are a few (very minor) items I picked up on:

  1. Line 325 of processingfile_v1 produced an error for me. I was able to run the chunks after it without a problem but I wanted to flag this in case it has the potential to cause further errors down the line.
  2. The readme file for the code folder refers to a preprocessing script, and it is referenced that way inside the body of processingfile_v1, but it may be helpful for reproducibility to either rename the processingfile_v1 or harmonize language around processing and preprocessing to avoid confusion.
  3. When I tried to render the manuscript file I received the following error: “functions that produce HTML output found in document targeting docx output. Please change the output type of this document to HTML. Alternatively, you can allow HTML output in non-HTML formats by adding this option to the YAML front-matter of your quarto file: prefer-html: true.”
  4. This is a very small one but I believe you still have Professor Handel as the author on some of the files so you could update that as well so that you are credited appropriately for all of the hard work you have done!

Well done, 3/3 👍

perezkm commented 1 year ago

Score: 3

Hi Weifan and Kailin,

Nice job!! Below are a couple notes. I think you all are well on your way to a polished product you will be proud of!

Great work, Weifan and Kailin!! I hope this helps!