search

Weilbyte / PVEDiscordDark

A Discord-like dark theme for the Proxmox Web UI.
MIT License
2.54k stars 240 forks source link

return red border around invalid form fields #116

Closed masonh closed 2 years ago

masonh commented 2 years ago

addresses #111

The 0-width border in this theme prevented the red error border from showing. This commit returns a 1px solid border with the same CSS selector as PVE's built-in theme and corrects for the corresponding layout disruption by adding a -1px margin. The built-in theme currently sets the border color to #cf4c35, which is not overridden.

image

Weilbyte commented 2 years ago

Thanks! Just one more thing before merge: please make sure your Sass compiler doesn't try to optimize the code (this has resulted in some odd things breaking in the past), but rather, just minify it.

masonh commented 2 years ago

The first compile was with ruby sass. I also tried sassc, which gets closer to yours but still converts some "-webkit" properties to the standard form and changes "top-background" (which I've never seen before) to "background". So I ended up copying the changed bit in by hand. Which sass compiler do you use?

Weilbyte commented 2 years ago

I use this VSCode extension, unsure what it uses under the hood.

masonh commented 2 years ago

I took a quick look and it appears to use libsass, which is also the library behind sassc. The libsass library has been deprecated and the extension you linked abandoned, so you may want to look into updating to this newer fork at some point.