RAnEn::generateAnalogs return error messages about not matching object types

Weiming-Hu / AnalogsEnsemble

The C++ and R packages for parallel ensemble forecasts using Analog Ensemble

https://weiming-hu.github.io/AnalogsEnsemble/

MIT License

18 stars 5 forks source link

RAnEn::generateAnalogs return error messages about not matching object types #49

Closed Weiming-Hu closed 5 years ago

Weiming-Hu commented 5 years ago

Hi Alon, could you please upload two things here to assist the debugging?

Run all the codes until the line that will give you the error message. Save the environment (you can remove and clear some variables that won't be used to reduce the file size. Normally it is enough that you save all the input the function that will generate the error) and try uploading it here or directly to me.
Attach the line of code here that you didn't run and will give you the error.

Thank you

AlonSidel commented 5 years ago

library(RAnEn)
AnEn.ASOS <- generateAnalogs(config)

Error in .generateAnalogs(configuration$test_forecasts, dim(configuration$test_forecasts), : Not compatible with requested type: [type=list; target=double].

WORKSPACE

Weiming-Hu commented 5 years ago

I have just arrived in SC. I will take a look at this very soon. Sorry ......

Weiming-Hu commented 5 years ago

Hi Alon, looks like I can't access this file. Did you share it to the right email (wuh20@psu.edu)? Sorry for not checking this earlier....

AlonSidel commented 5 years ago

Can you try again with this link? https://psu.box.com/s/e58o9j047t84kk49xv7o7f5s5586k0su

On Wed, Jun 26, 2019 at 9:31 AM Weiming notifications@github.com wrote:

Hi Alon, looks like I can't access this file. Did you share it to the right email (wuh20@psu.edu)? Sorry for not checking this earlier....

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Weiming-Hu/AnalogsEnsemble/issues/49?email_source=notifications&email_token=AKSAVW5HFJ74554X4HWX4ZTP4NVR3A5CNFSM4HXKMNNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYTQZPI#issuecomment-505875645, or mute the thread https://github.com/notifications/unsubscribe-auth/AKSAVW62HDPZQZCKREGVAK3P4NVR3ANCNFSM4HXKMNNA .

Weiming-Hu commented 5 years ago

This works. Thank you.

Weiming-Hu commented 5 years ago

Bug spotted. This issue reflects a fundamental problem in the checking function RAnEn::validateConfiguration. R is apparently not a pass-by-reference language so I need to rethink how to do the checks properly and efficiently. I will update once I have made changes.

Weiming-Hu commented 5 years ago

Hi Alon, Please update your RAnEn to the latest version. This should be resolved.

However, you are presented with another issue.

> AnEn.ASOS <- generateAnalogs(config)
Convert R objects to C++ objects ...
Computing standard deviation ... 
Computing mapping from forecast [Time, FLT] to observation [Time]  ... 
Warning: Could not find some forecast times in observation times. NA values might exist.
One-on-one matching search and test stations based on indices ...
Error: Search forecasts and observations should have same numbers of stations!
Error in .generateAnalogs(configuration$test_forecasts, dim(configuration$test_forecasts),  : 
  Error code: -70

This is because you have more stations in the forecasts but only 1 in the observations. You need to make them consistent. Please see if this works for you.

Weiming-Hu commented 5 years ago

Closing issue.