search

WeirdTreeThing / cros-keyboard-map

Utility to generate keyd configurations for use on Chromebooks
BSD 3-Clause "New" or "Revised" License
33 stars 10 forks source link

Improvements #9

Closed jenneron closed 4 months ago

WeirdTreeThing commented 4 months ago

Thanks for refactoring this, I've been neglecting it.

WeirdTreeThing commented 4 months ago

What else do you still need to do?

jenneron commented 4 months ago

What else do you still need to do?

You had 4 similar blocks of code, i unified it into get_functional_row() function. I hope it will make easier to make "inverted" feature. I'm looking at it right now

WeirdTreeThing commented 4 months ago

Yeah that was one thing I was lazy about when I first wrote it

jenneron commented 4 months ago

Also, since this function will use 3 variables: use_vivaldi, super_is_held and super_inverted it means that we will have a lot of possible combinations, and to avoid mistakes we will probably have to write a few tests for this function