WelcometoMyGarden / welcometomygarden

Web app of Welcome To My Garden, a not-for-profit network of citizens offering free camping spots in their gardens to slow travellers.
https://welcometomygarden.org
GNU Affero General Public License v3.0
107 stars 16 forks source link

Revert "feat: add Plausible event tracking" (experimental) #315

Closed th0rgall closed 1 year ago

th0rgall commented 1 year ago

This reverts commit 365881ddfeeca5789b88960953891dbe14e499a8.

These commits & deploys are intended to debug an issue that came up with dynamic routes. It seems to have been caused by yarn v1 being used on a yarn v3.x lockfile...

Error: Not found: /explore/garden/example-id
    at update (start.86883c9a.js:568:28)
    at navigate (start.86883c9a.js:1170:11)
    at goto (start.86883c9a.js:518:12)
    at Object.goto (start.86883c9a.js:1329:14)
    at Module.start (start.86883c9a.js:1760:12)
    at zN0Vj6Ef2dfQwVihb692JawWGIF2:165:11
github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 4dcae01):

https://wtmg-dev--pr315-test-sveltekit-error-3mgaeecx.web.app

(expires Tue, 04 Apr 2023 16:26:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7773005e481e8bc60fd60a58f2d818cc7378f95b

wardbeyens commented 1 year ago

nice!

th0rgall commented 1 year ago

@wardbeyens yep, both repositories (/api and the main one) now include a yarn executable in .yarn. I thought it was weird at first to commit the package manager, but it seems to be a best practice for Yarn v2+. And if you don't do it while someone has a v1 yarn installed... guaranteed that things break!

See also:

th0rgall commented 1 year ago

Closing because this is outdated, and relevant code got merged in another way.