search

WelcometoMyGarden / welcometomygarden

Web app of Welcome To My Garden, a not-for-profit network of citizens offering free camping spots in their gardens to slow travellers.
https://welcometomygarden.org
GNU Affero General Public License v3.0
107 stars 16 forks source link

Bug scroll issue in full screen mode #320

Closed wardbeyens closed 1 year ago

wardbeyens commented 1 year ago

I Can't scroll after I get redirected while still in fullscreen mode.

https://user-images.githubusercontent.com/45149049/234035231-225290c3-9b7c-4b57-aaa6-846a7ccd1e7f.webm

th0rgall commented 1 year ago

Ah, thanks for reporting!

Scrolling seems to work when I change 'body' to 'html' here https://github.com/WelcometoMyGarden/welcometomygarden/blob/4380a2598670384860b8c3e9684fa59c61029629/src/lib/components/Map/Map.svelte#L83-L88

but being able to navigate away from the map view while still in full-screen mode might lead to more unexpected situations. Maybe we will depend on the nav bars in other parts of the app. It's probably better to automatically exit fullscreen when exiting the map. I'll try to find if we can do that cleanly.

th0rgall commented 1 year ago

I think I found a way, see the commit linked above. Let me know if it is still broken.

wardbeyens commented 1 year ago

Yes this is fixed for me

Op wo 26 apr. 2023 16:11 schreef Thor Galle @.***>:

I think I found a way, see the commit linked above. Let me know if it is still broken.

— Reply to this email directly, view it on GitHub https://github.com/WelcometoMyGarden/welcometomygarden/issues/320#issuecomment-1523491889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKYOW6NJYDXM5G4CKOWVE6LXDEUJXANCNFSM6AAAAAAXJWSX6I . You are receiving this because you authored the thread.Message ID: @.***>