search

WendellAdriel / dev-curriculum

Instant web curriculum generator for developers
MIT License
291 stars 77 forks source link

Update footer.html #12

Closed khaosdoctor closed 8 years ago

khaosdoctor commented 8 years ago

We have to add the spaces or this won't work :D

WendellAdriel commented 8 years ago

Strange, in my page it's working, because I made some tests when I made this change: http://wendelladriel.github.io/

And the code is the same: https://github.com/WendellAdriel/WendellAdriel.github.io/blob/master/_includes/footer.html#L3

Are you sure that isn't working to you? What's happening?

khaosdoctor commented 8 years ago

I don't know, I though this was part of the liquid templates syntax... It shows only the URL to github, without the username. Changed to this and now it's working...

WendellAdriel commented 8 years ago

No, I made some tests here and it's ok. I will not close this PR now, I'll wait to merge it with the next version ok @khaosdoctor? Thanks for the help!

khaosdoctor commented 8 years ago

Ok 👌